19246[BUGFIX] Error in filelist for Storage context menu
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
-
Verified V +2
- Steffen Ritter +2
Issues 1
Files 3
Review log 3
-
Steffen Ritter commented on patch set 1 04/05/13, 19:12
I would prefer that you didn't submit thisClickMenu.php:710isFolderClickMenu.php:755online check missingClickMenu.php:787switch the conditions parameters for better performanceClickMenu.php:791isOnline and isFolder to front (performance)ClickMenu.php:795sameClickMenu.php:808same hereClickMenu.php:812same hereClickMenu.php:830please don't -- accidentilly deleting storages is to risky.ClickMenu.php:833check for write access to the folder? -
Steffen Ritter commented on patch set 1 V 0 04/05/13, 19:12
by team member; Looks good to me, approved merging to 6.0 as it's same as in master, remarks will be tackled in follow up -
Steffen Ritter merged patch set 2 04/05/13, 19:12