Review main Merged

23786[BUGFIX] Do not encode links from non-local storages

Helmut Hummel CR +2 V +2 Easy +4 −4 updated 11/05/13, 13:59

Commit message

The check for non file URLs that was introduced
in #42223 does not take relative URLs into account,
which are also perfectly valid for some drivers.

Just check if the image resource URL is a local
file, because only then it makes sense to maybe
transform it to a GIF.

We also remove an obsolete check for file
in imageLinkWrap as the URL there can be either
an URL to a remote storage or an integer.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Issues 2

Files 1

Review log 9

  1. Mr. Jenkins commented on patch set 1 09/12/13, 12:41

  2. Dietrich Heise voted on patch set 1 V +1 CR +1 09/12/13, 12:44

  3. Helmut Hummel uploaded patch set 2 09/12/13, 15:04

  4. Mr. Jenkins commented on patch set 2 09/12/13, 15:05

  5. Dietrich Heise voted on patch set 2 V +1 CR +1 09/13/13, 12:21

  6. Helmut Hummel rebased onto patch set 2 11/05/13, 13:47

  7. Helmut Hummel voted on patch set 3 V +2 CR +2 11/05/13, 13:48

  8. Helmut Hummel merged patch set 4 11/05/13, 13:48

  9. Mr. Jenkins commented on patch set 3 11/05/13, 13:59