Review main Merged

34544[TASK] Correct table rendering

Benjamin Kott CR +2 V +2 Normal +55 −88 updated 11/25/14, 08:27

Commit message

* add darker panel header to remain visual identity
* add nowrap for th in typo3 tables
* remove obsolete db_list_normal class and definitions
* remove obsolete pagination styling from beusers
* fix padding list module table styling
* fix beuser table listing

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • Wouter Wolters +1
    • Felix Kopp +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • Wouter Wolters +1
    • Felix Kopp +1

Issues 1

Files 13

Review log 12

  1. Benjamin Kott uploaded patch set 1 11/24/14, 12:30

  2. Felix Kopp commented on patch set 1 11/24/14, 12:52

    Nice WIP. -> I would like to include the removal of row-header classes into this patch as well. What do you think?

    IndexListRow.html:16

    Tabs

    IndexListRow.html:39

    You ask you? Rather horizontal scrolling in smaller screens than hidden information.

    Index.html:71

    Collapses currently should be no-wrap

    _element_panel.less:20

    Tab Great!

    _element_table.less:68

    Tab > thead, > tbody, > tfoot { >tr> th {} }
  3. Felix Kopp commented on patch set 1 11/24/14, 12:54

    As explanation: in order to reduce the amount of visual changes with 7 - we now re-include few borders and darker table header.
  4. Benjamin Kott commented on patch set 1 11/24/14, 13:18

    IndexListRow.html:16 Reply

    Done

    IndexListRow.html:39 Reply

    At this point - these classes caused the problems with the missing border. We dont have a clear concept yet when to show and when to hide what so for me its fine to scroll instead of hiding stuff.

    Index.html:71 Reply

    I do not really understand what you are trying to tell me ;)

    _element_panel.less:20 Reply

    Hate this switching between projecs so sorry...

    _element_table.less:68 Reply

    Done
  5. Benjamin Kott uploaded patch set 2 11/24/14, 13:18

  6. Felix Kopp commented on patch set 1 11/24/14, 14:43

    Index.html:71 Reply

    The column on OS X on chrome breaks into several lines on spaces in date info
  7. Felix Kopp commented on patch set 1 11/24/14, 14:47

    _element_panel.less:20 Reply

    Done
  8. Felix Kopp voted on patch set 2 CR +1 V +1 11/24/14, 14:55

  9. Wouter Wolters voted on patch set 2 V +1 CR +1 11/24/14, 21:57

  10. Mathias Schreiber voted on patch set 2 CR +1 V +1 11/25/14, 08:13

  11. Frank Nägler voted on patch set 2 V +2 CR +2 11/25/14, 08:27

  12. Frank Nägler merged patch set 2 11/25/14, 08:27