34544[TASK] Correct table rendering
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Mathias Schreiber +1
- Wouter Wolters +1
- Felix Kopp +1
-
Verified V +2
- Frank Nägler +2
- Mathias Schreiber +1
- Wouter Wolters +1
- Felix Kopp +1
Issues 1
Files 13
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+2 −2
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.html4+4 −6
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/OnlineListRow.html+1 −1
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Index.html3+5 −6
- typo3/sysext/beuser/Resources/Public/Css/style.css+0 −23
- typo3/sysext/linkvalidator/Resources/Private/Templates/mod_template.html+2 −2
- typo3/sysext/t3skin/Resources/Private/Styles/bootstrap/variables.less+2 −2
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/structure/_module_web_list.less+0 −6
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/_element_panel.less3+2 −3
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/_element_table.less2+19 −15
- typo3/sysext/t3skin/Resources/Public/Css/visual/t3skin.css+16 −20
- typo3/sysext/wizard_sortpages/Classes/View/SortPagesWizardModuleFunction.php+1 −1
Review log 12
-
Benjamin Kott uploaded patch set 1 11/24/14, 12:30
-
Felix Kopp commented on patch set 1 11/24/14, 12:52
Nice WIP. -> I would like to include the removal of row-header classes into this patch as well. What do you think?IndexListRow.html:16TabsIndexListRow.html:39You ask you? Rather horizontal scrolling in smaller screens than hidden information.Index.html:71Collapses currently should be no-wrap_element_panel.less:20Tab Great!_element_table.less:68Tab > thead, > tbody, > tfoot { >tr> th {} } -
Felix Kopp commented on patch set 1 11/24/14, 12:54
As explanation: in order to reduce the amount of visual changes with 7 - we now re-include few borders and darker table header. -
Benjamin Kott commented on patch set 1 11/24/14, 13:18
IndexListRow.html:16ReplyDoneIndexListRow.html:39ReplyAt this point - these classes caused the problems with the missing border. We dont have a clear concept yet when to show and when to hide what so for me its fine to scroll instead of hiding stuff.Index.html:71ReplyI do not really understand what you are trying to tell me ;)_element_panel.less:20ReplyHate this switching between projecs so sorry..._element_table.less:68ReplyDone -
Benjamin Kott uploaded patch set 2 11/24/14, 13:18
-
Felix Kopp commented on patch set 1 11/24/14, 14:43
Index.html:71ReplyThe column on OS X on chrome breaks into several lines on spaces in date info -
Felix Kopp commented on patch set 1 11/24/14, 14:47
_element_panel.less:20ReplyDone -
Felix Kopp voted on patch set 2 CR +1 V +1 11/24/14, 14:55
-
Wouter Wolters voted on patch set 2 V +1 CR +1 11/24/14, 21:57
-
Mathias Schreiber voted on patch set 2 CR +1 V +1 11/25/14, 08:13
-
Frank Nägler voted on patch set 2 V +2 CR +2 11/25/14, 08:27
-
Frank Nägler merged patch set 2 11/25/14, 08:27