37586[BUGFIX] File metadata can’t be edited inline
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Christian Kuhn +1
- Daniel Maier +1
- Benni Mack +1
-
Verified V +2
- Andreas Wolf +2
- Christian Kuhn +1
- Daniel Maier +1
Issues 1
Files 2
Review log 20
-
Andreas Wolf uploaded patch set 1 03/06/15, 09:40
-
Andreas Wolf uploaded patch set 2 03/06/15, 09:51
-
Alexander Krist voted on patch set 2 CR +1 V +1 03/10/15, 15:06
-
Georg Ringer commented on patch set 2 CR +2 03/11/15, 05:16
-
Frank Nägler commented on patch set 2 03/15/15, 16:05
InlineElement.php:2231Replymaybe because an empty string would be casted to 0 ? not sure -
Andreas Wolf commented on patch set 2 03/16/15, 07:14
InlineElement.php:2231ReplyThe id should never be an empty string. Georg is right; I just copied the check from EditDocumentController. If we change it here, we should also change it there to have it consistent. -
Andreas Kienast uploaded patch set 3 04/09/15, 08:13
-
Andreas Wolf uploaded patch set 4 04/20/15, 09:16
-
Markus Klein voted on patch set 4 CR +1 04/20/15, 12:12
-
Michael Knoll voted on patch set 4 CR +1 V +1 04/20/15, 14:18
-
Michael Knoll voted on patch set 4 V 0 04/20/15, 14:18
-
Benni Mack uploaded patch set 5 06/15/15, 10:05
-
Benni Mack voted on patch set 5 CR +1 06/15/15, 10:05
-
Daniel Maier voted on patch set 5 CR +1 V +1 06/15/15, 17:21
-
Markus Klein commented on patch set 5 06/16/15, 08:43
This describes the bug and not what is changed -
Christian Kuhn commented on patch set 5 V +1 CR +1 06/16/15, 09:06
ok, fine with me. imho the commit message is ok, too. ok for backport to 6.2 -
Andreas Wolf voted on patch set 5 CR +2 V +2 06/16/15, 09:08
-
Andreas Wolf merged patch set 5 06/16/15, 09:08
-
Stephan Großberndt commented on patch set 6 06/16/15, 18:07
Backport in https://review.typo3.org/#/c/40323/1 -
Stephan Großberndt commented on patch set 6 06/16/15, 18:21
Should typo3\sysext\recycler\Classes\Utility\RecyclerUtility.php->checkAccess() and typo3\sysext\backend\Classes\Controller\Wizard\AbstractWizardController.php->checkEditAccess() be adapted accordingly to check $isRootLevelRestrictionIgnored too?
InlineElement.php:2231