Review main Merged

37586[BUGFIX] File metadata can’t be edited inline

Andreas Wolf CR +2 V +2 Easy +4 −3 updated 06/16/15, 18:21

Commit message

Since 2012, there is a special mechanism to allow some tables for
editing even if their records reside on a page that is inaccessible for
the user. This is checked for regular forms in
``EditDocumentController``, but the check for inline elements was
missing until this patch.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Christian Kuhn +1
    • Daniel Maier +1
    • Benni Mack +1
  • Verified V +2
    • Andreas Wolf +2
    • Christian Kuhn +1
    • Daniel Maier +1

Issues 1

Files 2

Review log 20

  1. Andreas Wolf uploaded patch set 1 03/06/15, 09:40

  2. Andreas Wolf uploaded patch set 2 03/06/15, 09:51

  3. Alexander Krist voted on patch set 2 CR +1 V +1 03/10/15, 15:06

  4. Georg Ringer commented on patch set 2 CR +2 03/11/15, 05:16

    InlineElement.php:2231

    is there a reason to cast that to a string instead of int? the pid should alwasy be an int?!
  5. Frank Nägler commented on patch set 2 03/15/15, 16:05

    InlineElement.php:2231 Reply

    maybe because an empty string would be casted to 0 ? not sure
  6. Andreas Wolf commented on patch set 2 03/16/15, 07:14

    InlineElement.php:2231 Reply

    The id should never be an empty string. Georg is right; I just copied the check from EditDocumentController. If we change it here, we should also change it there to have it consistent.
  7. Andreas Kienast uploaded patch set 3 04/09/15, 08:13

  8. Andreas Wolf uploaded patch set 4 04/20/15, 09:16

  9. Markus Klein voted on patch set 4 CR +1 04/20/15, 12:12

  10. Michael Knoll voted on patch set 4 CR +1 V +1 04/20/15, 14:18

  11. Michael Knoll voted on patch set 4 V 0 04/20/15, 14:18

  12. Benni Mack uploaded patch set 5 06/15/15, 10:05

  13. Benni Mack voted on patch set 5 CR +1 06/15/15, 10:05

  14. Daniel Maier voted on patch set 5 CR +1 V +1 06/15/15, 17:21

  15. Markus Klein commented on patch set 5 06/16/15, 08:43

    This describes the bug and not what is changed
  16. Christian Kuhn commented on patch set 5 V +1 CR +1 06/16/15, 09:06

    ok, fine with me. imho the commit message is ok, too. ok for backport to 6.2
  17. Andreas Wolf voted on patch set 5 CR +2 V +2 06/16/15, 09:08

  18. Andreas Wolf merged patch set 5 06/16/15, 09:08

  19. Stephan Großberndt commented on patch set 6 06/16/15, 18:07

  20. Stephan Großberndt commented on patch set 6 06/16/15, 18:21

    Should typo3\sysext\recycler\Classes\Utility\RecyclerUtility.php->checkAccess() and typo3\sysext\backend\Classes\Controller\Wizard\AbstractWizardController.php->checkEditAccess() be adapted accordingly to check $isRootLevelRestrictionIgnored too?