Review main Merged

43876[BUGFIX] Load test classes in non composer mode

Helmut Hummel CR +2 V +2 Normal +155 −11 updated 10/07/15, 17:40

Commit message

In non composer mode it has been impossible to register
classes for tests to be loaded (e.g. fixture classes) as long
as at least one autoload information was registered in the extension.

With this change, we will now evaluate an autoload-dev section
as well and also do not skip the scan of test classes when no autoload
section is defined in the extension for better backwards compatibility.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Nicole Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Nicole Hummel +1

Issues 1

Files 3

Review log 8

  1. Helmut Hummel uploaded patch set 1 10/06/15, 22:50

  2. Helmut Hummel uploaded patch set 2 10/07/15, 15:27

  3. Nicole Hummel uploaded patch set 3 10/07/15, 16:10

  4. Nicole Hummel commented on patch set 2 10/07/15, 16:10

    ClassLoadingInformationGeneratorTest.php:370

    array
  5. Nicole Hummel commented on patch set 2 10/07/15, 16:10

    ClassLoadingInformationGeneratorTest.php:370 Reply

    Done
  6. Nicole Hummel voted on patch set 3 CR +1 V +1 10/07/15, 16:10

  7. Wouter Wolters voted on patch set 3 V +2 CR +2 10/07/15, 17:40

  8. Wouter Wolters merged patch set 3 10/07/15, 17:40