Review main Merged

44420[FOLLOWUP][BUGFIX] PageLayoutController must only use available actions for view/edit

Andreas Allacher CR +2 V +2 Easy +3 −1 updated 10/31/15, 10:35

Commit message

Ensure that only available actions are shown via PageLayoutController,
e.g. if you remove QuickEdit and the user had previously set the module
to QuickEdit.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
    • Andreas Kienast +1
    • Michael Oehlhof +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1

Issues 1

Files 1

Review log 7

  1. Andreas Allacher uploaded patch set 1 10/30/15, 17:38

  2. Andreas Allacher commented on patch set 1 10/30/15, 18:21

    fixes that switching actions doesn't work with the bugfix itself anymore because the loop reset the defaultKey in later iterations.
  3. Andreas Kienast voted on patch set 1 CR +1 10/30/15, 18:39

  4. Michael Oehlhof voted on patch set 1 CR +1 10/30/15, 20:42

  5. Jan Helke voted on patch set 1 CR +1 V +1 10/31/15, 10:31

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 10/31/15, 10:35

  7. Christian Kuhn merged patch set 1 10/31/15, 10:35