Review main Abandoned

51817[BUGFIX] Update comparison for datetime storage

Marc Neuhaus CR 0 V 0 Normal +108 −5 updated 11/03/21, 15:05

Commit message

Since the introduction of the new datetime storage format the comparisons
fail to work with non integer date columns, because the comparison
parameter was configured to be an integer. This commit checks, if the
column is a timestamp or datetime column and uses PDO::PARAM_STR for
datetime and PDO::PARAM_INT for timestamp columns. Additionally the
datamapper->getPlainValue methods needs the according columnMap in
order to convert any non UTC DateTimes into UTC, because datetime
columns need to be stored in UTC to prevent timezone problems, since
MySQL datetime columns can not store timezone information.
The Testbase->importXmlDatabaseFixture method was also changed
to apply the needed timezone conversion into UTC.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 1624

  1. Marc Neuhaus uploaded patch set 1 02/24/17, 08:39

  2. Marc Neuhaus updated the commit message in patch set 2 02/24/17, 08:41

  3. TYPO3com voted on patch set 1 V -1 02/24/17, 08:51 Completed build in 11m 59s on Fri, 24 Feb, 09:51 AM Test Summary: 10 of 56478 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8450

  4. TYPO3com voted on patch set 2 V -1 02/24/17, 08:55 Completed build in 13m 14s on Fri, 24 Feb, 09:55 AM Test Summary: 10 of 56478 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8451

  5. Thomas Hohn commented on patch set 2 02/24/17, 09:20

    What about the failing tests?

    QueryParserTest.php:209

    Is there a reason for this empty method?
  6. Benni Mack commented on patch set 2 12/27/17, 14:34

    Care to update the patch, Marc?
  7. Mathias Schreiber uploaded patch set 3 02/10/18, 12:41

  8. TYPO3com voted on patch set 3 V -1 02/10/18, 12:42 Completed build in 11s on Sat, 10 Feb, 01:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19276

  9. Mathias Schreiber uploaded patch set 4 02/10/18, 12:43

  10. Mathias Schreiber updated the commit message in patch set 5 02/10/18, 12:44

  11. TYPO3com voted on patch set 4 V -1 02/10/18, 12:52 Completed build in 09m 23s on Sat, 10 Feb, 01:52 PM Test Summary: 10 of 30645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19277

  12. TYPO3com voted on patch set 5 V -1 02/10/18, 12:54 Completed build in 09m 37s on Sat, 10 Feb, 01:54 PM Test Summary: 10 of 30645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19278

  13. Oliver Klee updated the commit message in patch set 6 02/10/18, 14:00

  14. Oliver Klee commented on patch set 6 02/10/18, 14:01

    This clearly still is a WIP. Marked as such.
  15. TYPO3com voted on patch set 6 V -1 02/10/18, 14:08 Completed build in 07m 44s on Sat, 10 Feb, 03:08 PM Test Summary: 11 of 30645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19282

  16. Christian Kuhn abandoned the change 09/19/18, 18:51

    hey. i'm abandoning this wip patch since basically nothing happened here since it has been firs pushed. i'll reset the issue to new, maybe it is picked up again. if further work happens on this patch, it can be resurrected.
  17. Benni Mack restored the change 06/03/20, 13:05

  18. Benni Mack uploaded patch set 7 06/03/20, 13:09

  19. TYPO3com voted on patch set 7 V -1 06/03/20, 13:22 Completed build in 12m 24s on Wed, 3 Jun, 01:22 PM Test Summary: 36 of 73353 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3775

  20. Benni Mack rebased onto patch set 8 10/09/20, 10:27

  21. Oliver Klee wrote 10/09/20, 10:37

    Removed reviewer Oliver Klee.
  22. TYPO3com voted on patch set 8 V -1 10/09/20, 10:42 Completed build in 14m 15s on Fri, 9 Oct, 10:42 AM Test Summary: 36 of 74279 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6395

  23. Christian Kuhn commented on patch set 8 11/03/21, 15:05

    Hey. I'll abandon this patch for now and hope it's ok to do so at the moment. As always, it can of course be resurrected or rediscussed in case active contribution continues.
  24. Christian Kuhn abandoned the change 11/03/21, 15:05