Issue Bug Closed

#79473Typo3DbQueryParser fails since Doctrine by comparing date fields

Georg Ringer 01/26/17, 08:36 updated 12/02/25, 14:36

Description

Since the move to native Doctrine querybuilding in extbase with #77379, the comparing using calls like greaterThan,lessThan,… fail if a date field should be compared.

The error can easily be spotted by taking a look into the method parseDynamicOperand Github

case QueryInterface::OPERATOR_LESS_THAN_OR_EQUAL_TO:
                $value = $this->queryBuilder->createNamedParameter($this->dataMapper->getPlainValue($value), \PDO::PARAM_INT);
                $expr = $exprBuilder->comparison($fieldName, $exprBuilder::LTE, $value);
                break;

Using PDO::PARAM_INT is wrong if in the DB an actual date or datetime type is used.

Reviews 5

History 2749

Show 1424 earlier messages
  1. Markus Klein changed target version Sprint Focus Stabilization Sprint <span data-processor="relativetime" data-value="2017-02-21T00:57:17+00:00" > 02/21/17, 00:57 </span>

  2. Frank Nägler commented <span data-processor="relativetime" data-value="2017-03-24T12:33:48+00:00" > 03/24/17, 12:33 </span>

    did extbase support date and datetime fields? imho only int (unix timestamp) is supported, correct me if I am wrong.

  3. Jigal van Hemert commented <span data-processor="relativetime" data-value="2017-03-29T23:00:38+00:00" > 03/29/17, 23:00 </span>

    \TYPO3\CMS\Extbase\Persistence\Generic\Mapper\DataMapper::getPlainValue() already takes care of \DateTime objects and the date / datetime database fields. There seems to be no reason to use \PDO::PARAM_INT in \TYPO3\CMS\Extbase\Persistence\Generic\Storage\Typo3DbQueryParser::parseDynamicOperand() for certain operators and \PDO::PARAM_STR (the default) for other operators.

  4. Christian Kuhn changed target version Sprint Focus Stabilization Sprint <span data-processor="relativetime" data-value="2017-04-02T20:31:20+00:00" > 04/02/17, 20:31 </span>

  5. Riccardo De Contardi commented <span data-processor="relativetime" data-value="2017-04-28T21:45:53+00:00" > 04/28/17, 21:45 </span>

    I write here the description of #80978 to keep track of it:

    > it takes me hours to find out that all comparisons numbers parsed to Integer!!!
    > Please also take care of floating point numbers when you convert the TYPO3 QueryBuilder to Doctrine QueryBilder in Typo3DbQueryParser class.
    >
    > Bug-Snippet of Typo3DbQueryParser.php:

               case QueryInterface::OPERATOR_LESS_THAN:
                    $value = $this->queryBuilder->createNamedParameter($this->dataMapper->getPlainValue($value), \PDO::PARAM_INT);
                    $expr = $exprBuilder->comparison($fieldName, $exprBuilder::LT, $value);
                    break;
                case QueryInterface::OPERATOR_LESS_THAN_OR_EQUAL_TO:
                    $value = $this->queryBuilder->createNamedParameter($this->dataMapper->getPlainValue($value), \PDO::PARAM_INT);
                    $expr = $exprBuilder->comparison($fieldName, $exprBuilder::LTE, $value);
                    break;
                case QueryInterface::OPERATOR_GREATER_THAN:
                    $value = $this->queryBuilder->createNamedParameter($this->dataMapper->getPlainValue($value), \PDO::PARAM_INT);
                    $expr = $exprBuilder->comparison($fieldName, $exprBuilder::GT, $value);
                    break;
                case QueryInterface::OPERATOR_GREATER_THAN_OR_EQUAL_TO:
                    $value = $this->queryBuilder->createNamedParameter($this->dataMapper->getPlainValue($value), \PDO::PARAM_INT);
                    $expr = $exprBuilder->comparison($fieldName, $exprBuilder::GTE, $value);
                    break;
  6. Christian Toffolo commented <span data-processor="relativetime" data-value="2017-05-14T13:16:46+00:00" > 05/14/17, 13:16 </span>

    I add myself to all those that wasted hours because of this bug.

    I’m not a developer, but isn’t this as simple to fix as changing “\PDO::PARAM_INT” with “\PDO::PARAM_STR”?

    @Riccardo: another related one is https://forge.typo3.org/issues/81056

  7. Gerrit Code Review pushed patch set 1 for master to change 52802 status Accepted Under Review <span data-processor="relativetime" data-value="2017-05-14T14:25:05+00:00" > 05/14/17, 14:25 </span>

  1. Christian Toffolo commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2017-06-17T21:30:05+00:00" > 06/17/17, 21:30 </span>

    Applied in changeset commit:0bd1746384980d9f6f7387d8638d280443ee843b.

  2. Gerrit Code Review pushed patch set 5 for master to change 51817 status Resolved Under Review <span data-processor="relativetime" data-value="2018-02-10T13:44:45+00:00" > 02/10/18, 13:44 </span>

  3. Christian Kuhn changed status Under Review New removed the assignee <span data-processor="relativetime" data-value="2018-09-19T20:50:11+00:00" > 09/19/18, 20:50 </span>

  4. Gerrit Code Review pushed patch set 7 for master to change 51817 status Accepted Under Review <span data-processor="relativetime" data-value="2020-06-03T15:10:02+00:00" > 06/03/20, 15:10 </span>

  5. Benjamin Franzke commented and changed status Under Review Resolved <span data-processor="relativetime" data-value="2025-04-11T08:15:12+00:00" > 04/11/25, 08:15 </span>

    Applied in changeset commit:8d2761ad5a2deaf2ff58e7a0e60ba0cfd8c1c49b.