#79473Typo3DbQueryParser fails since Doctrine by comparing date fields
Description
Since the move to native Doctrine querybuilding in extbase with #77379, the comparing using calls like greaterThan,lessThan,… fail if a date field should be compared.
The error can easily be spotted by taking a look into the method parseDynamicOperand Github
case QueryInterface::OPERATOR_LESS_THAN_OR_EQUAL_TO:
$value = $this->queryBuilder->createNamedParameter($this->dataMapper->getPlainValue($value), \PDO::PARAM_INT);
$expr = $exprBuilder->comparison($fieldName, $exprBuilder::LTE, $value);
break;
Using PDO::PARAM_INT is wrong if in the DB an actual date or datetime type is used.
Reviews 5
- 13.4 88951[BUGFIX] Fix native datetime transformation in Extbase query constraints
- main 88840[BUGFIX] Fix native datetime transformation in Extbase query constraints
- main 51817[BUGFIX] Update comparison for datetime storage
- TYPO3_8-7 53244[BUGFIX] Use the correct named parameter type in Extbase queries
- main 52802[BUGFIX] Use the correct named parameter type in Extbase queries
Related issues 5
- Bug #63482Query constraint on a DateTime field with a DateTime argument should trigger date format
- Bug #77379Doctrine: Migrate extbase Typo3DbBackend and Typo3DbQueryParser
- Bug #81019Query Builder: Error when ordering by DateTime fields
- Bug #81056Query Builder fails on greater / less comparisons on string fields
- Epic #90106[Extbase] Priority Bugfixes
History 2749
Show 1424 earlier messages
-
Josef Glatz changed description <span data-processor="relativetime" data-value="2017-01-26T09:07:00+00:00" > 01/26/17, 09:07 </span>
-
Markus Klein changed target version Sprint Focus Stabilization Sprint <span data-processor="relativetime" data-value="2017-02-21T00:57:17+00:00" > 02/21/17, 00:57 </span>
-
Marc Neuhaus changed assigned to Marc Neuhaus <span data-processor="relativetime" data-value="2017-02-23T19:48:06+00:00" > 02/23/17, 19:48 </span>
-
Jigal van Hemert commented <span data-processor="relativetime" data-value="2017-03-29T23:00:38+00:00" > 03/29/17, 23:00 </span>
\TYPO3\CMS\Extbase\Persistence\Generic\Mapper\DataMapper::getPlainValue() already takes care of \DateTime objects and the date / datetime database fields. There seems to be no reason to use \PDO::PARAM_INT in \TYPO3\CMS\Extbase\Persistence\Generic\Storage\Typo3DbQueryParser::parseDynamicOperand() for certain operators and \PDO::PARAM_STR (the default) for other operators.
-
Christian Kuhn changed target version Sprint Focus
Stabilization Sprint<span data-processor="relativetime" data-value="2017-04-02T20:31:20+00:00" > 04/02/17, 20:31 </span> -
Mona Muzaffar changed Related to #80852 <span data-processor="relativetime" data-value="2017-04-15T00:59:28+00:00" > 04/15/17, 00:59 </span>
-
Georg Ringer changed
Related to #80852<span data-processor="relativetime" data-value="2017-04-24T18:40:00+00:00" > 04/24/17, 18:40 </span> -
Georg Ringer changed Duplicated by #80978 <span data-processor="relativetime" data-value="2017-04-24T18:40:27+00:00" > 04/24/17, 18:40 </span>
-
Georg Ringer changed Related to #81019 <span data-processor="relativetime" data-value="2017-04-26T22:42:38+00:00" > 04/26/17, 22:42 </span>
-
Riccardo De Contardi commented <span data-processor="relativetime" data-value="2017-04-28T21:45:53+00:00" > 04/28/17, 21:45 </span>
I write here the description of #80978 to keep track of it:
> it takes me hours to find out that all comparisons numbers parsed to Integer!!!
> Please also take care of floating point numbers when you convert the TYPO3 QueryBuilder to Doctrine QueryBilder in Typo3DbQueryParser class.
>
> Bug-Snippet of Typo3DbQueryParser.php:case QueryInterface::OPERATOR_LESS_THAN: $value = $this->queryBuilder->createNamedParameter($this->dataMapper->getPlainValue($value), \PDO::PARAM_INT); $expr = $exprBuilder->comparison($fieldName, $exprBuilder::LT, $value); break; case QueryInterface::OPERATOR_LESS_THAN_OR_EQUAL_TO: $value = $this->queryBuilder->createNamedParameter($this->dataMapper->getPlainValue($value), \PDO::PARAM_INT); $expr = $exprBuilder->comparison($fieldName, $exprBuilder::LTE, $value); break; case QueryInterface::OPERATOR_GREATER_THAN: $value = $this->queryBuilder->createNamedParameter($this->dataMapper->getPlainValue($value), \PDO::PARAM_INT); $expr = $exprBuilder->comparison($fieldName, $exprBuilder::GT, $value); break; case QueryInterface::OPERATOR_GREATER_THAN_OR_EQUAL_TO: $value = $this->queryBuilder->createNamedParameter($this->dataMapper->getPlainValue($value), \PDO::PARAM_INT); $expr = $exprBuilder->comparison($fieldName, $exprBuilder::GTE, $value); break; -
Christian Toffolo commented <span data-processor="relativetime" data-value="2017-05-14T13:16:46+00:00" > 05/14/17, 13:16 </span>
I add myself to all those that wasted hours because of this bug.
I’m not a developer, but isn’t this as simple to fix as changing “\PDO::PARAM_INT” with “\PDO::PARAM_STR”?
@Riccardo: another related one is https://forge.typo3.org/issues/81056
-
Gerrit Code Review pushed patch set 1 for master to change 52802 status
AcceptedUnder Review <span data-processor="relativetime" data-value="2017-05-14T14:25:05+00:00" > 05/14/17, 14:25 </span> -
Riccardo De Contardi changed Related to #81056 <span data-processor="relativetime" data-value="2017-05-14T16:47:07+00:00" > 05/14/17, 16:47 </span>
-
Gerrit Code Review pushed patch set 2 for master to change 52802 <span data-processor="relativetime" data-value="2017-05-15T21:53:39+00:00" > 05/15/17, 21:53 </span>
-
Gerrit Code Review pushed patch set 3 for master to change 52802 <span data-processor="relativetime" data-value="2017-05-15T22:10:03+00:00" > 05/15/17, 22:10 </span>
-
Gerrit Code Review pushed patch set 4 for master to change 52802 <span data-processor="relativetime" data-value="2017-05-16T09:38:28+00:00" > 05/16/17, 09:38 </span>
-
Gerrit Code Review pushed patch set 5 for master to change 52802 <span data-processor="relativetime" data-value="2017-05-16T11:50:28+00:00" > 05/16/17, 11:50 </span>
-
Gerrit Code Review pushed patch set 6 for master to change 52802 <span data-processor="relativetime" data-value="2017-05-16T12:04:21+00:00" > 05/16/17, 12:04 </span>
-
Gerrit Code Review pushed patch set 7 for master to change 52802 <span data-processor="relativetime" data-value="2017-05-16T15:07:38+00:00" > 05/16/17, 15:07 </span>
-
Gerrit Code Review pushed patch set 8 for master to change 52802 <span data-processor="relativetime" data-value="2017-05-16T15:53:54+00:00" > 05/16/17, 15:53 </span>
-
Gerrit Code Review pushed patch set 9 for master to change 52802 <span data-processor="relativetime" data-value="2017-05-16T16:02:02+00:00" > 05/16/17, 16:02 </span>
-
Gerrit Code Review pushed patch set 10 for master to change 52802 <span data-processor="relativetime" data-value="2017-06-03T16:51:34+00:00" > 06/03/17, 16:51 </span>
-
Morton Jonuschat changed Duplicated by #81487 <span data-processor="relativetime" data-value="2017-06-07T01:36:42+00:00" > 06/07/17, 01:36 </span>
-
Gerrit Code Review pushed patch set 11 for master to change 52802 <span data-processor="relativetime" data-value="2017-06-07T23:30:52+00:00" > 06/07/17, 23:30 </span>
-
Gerrit Code Review pushed patch set 12 for master to change 52802 <span data-processor="relativetime" data-value="2017-06-17T20:08:36+00:00" > 06/17/17, 20:08 </span>
-
Gerrit Code Review pushed patch set 13 for master to change 52802 <span data-processor="relativetime" data-value="2017-06-17T20:15:56+00:00" > 06/17/17, 20:15 </span>
-
Gerrit Code Review pushed patch set 1 for TYPO3_8-7 to change 53244 <span data-processor="relativetime" data-value="2017-06-17T21:13:16+00:00" > 06/17/17, 21:13 </span>
-
Christian Toffolo commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2017-06-17T21:30:05+00:00" > 06/17/17, 21:30 </span>Applied in changeset commit:0bd1746384980d9f6f7387d8638d280443ee843b.
-
Riccardo De Contardi changed Related to #81719 <span data-processor="relativetime" data-value="2017-06-27T21:26:57+00:00" > 06/27/17, 21:26 </span>
-
Georg Ringer changed Related to #63482 <span data-processor="relativetime" data-value="2018-01-03T14:19:33+00:00" > 01/03/18, 14:19 </span>
-
Gerrit Code Review pushed patch set 5 for master to change 51817 status
ResolvedUnder Review <span data-processor="relativetime" data-value="2018-02-10T13:44:45+00:00" > 02/10/18, 13:44 </span> -
Gerrit Code Review pushed patch set 6 for master to change 51817 <span data-processor="relativetime" data-value="2018-02-10T15:00:54+00:00" > 02/10/18, 15:00 </span>
-
Christian Kuhn changed status
Under ReviewNew removed the assignee <span data-processor="relativetime" data-value="2018-09-19T20:50:11+00:00" > 09/19/18, 20:50 </span> -
Alexander Schnitzler changed status
NewAccepted parent task #90106 <span data-processor="relativetime" data-value="2020-01-16T11:51:24+00:00" > 01/16/20, 11:51 </span> -
Gerrit Code Review pushed patch set 7 for master to change 51817 status
AcceptedUnder Review <span data-processor="relativetime" data-value="2020-06-03T15:10:02+00:00" > 06/03/20, 15:10 </span> -
Gerrit Code Review pushed patch set 8 for master to change 51817 <span data-processor="relativetime" data-value="2020-10-09T12:28:03+00:00" > 10/09/20, 12:28 </span>
-
Oliver Hader changed Is Regression
10 <span data-processor="relativetime" data-value="2020-12-04T16:17:47+00:00" > 12/04/20, 16:17 </span> -
Christian Kuhn changed status
Under ReviewNew <span data-processor="relativetime" data-value="2021-11-03T15:06:31+00:00" > 11/03/21, 15:06 </span> -
Christian Kuhn changed
parent task #90106<span data-processor="relativetime" data-value="2022-02-19T11:11:43+00:00" > 02/19/22, 11:11 </span> -
Christian Kuhn changed Related to #90106 <span data-processor="relativetime" data-value="2022-02-19T11:11:51+00:00" > 02/19/22, 11:11 </span>
-
Markus Klein changed
Related to #81719<span data-processor="relativetime" data-value="2023-07-05T21:38:30+00:00" > 07/05/23, 21:38 </span> -
Markus Klein changed Duplicated by #81719 <span data-processor="relativetime" data-value="2023-07-05T21:38:38+00:00" > 07/05/23, 21:38 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 88840 status
NewUnder Review <span data-processor="relativetime" data-value="2025-04-10T08:09:38+00:00" > 04/10/25, 08:09 </span> -
Gerrit Code Review pushed patch set 3 for 13.4 to change 88951 <span data-processor="relativetime" data-value="2025-04-10T08:10:42+00:00" > 04/10/25, 08:10 </span>
-
Gerrit Code Review pushed patch set 4 for 13.4 to change 88951 <span data-processor="relativetime" data-value="2025-04-10T08:32:48+00:00" > 04/10/25, 08:32 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 88840 <span data-processor="relativetime" data-value="2025-04-10T08:33:42+00:00" > 04/10/25, 08:33 </span>
-
Benjamin Franzke commented and changed status
Under ReviewResolved <span data-processor="relativetime" data-value="2025-04-11T08:15:12+00:00" > 04/11/25, 08:15 </span>Applied in changeset commit:8d2761ad5a2deaf2ff58e7a0e60ba0cfd8c1c49b.
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T14:36:44+00:00" > 12/02/25, 14:36 </span>
did extbase support date and datetime fields? imho only int (unix timestamp) is supported, correct me if I am wrong.