Review main Merged

53363[BUGFIX] EXT:form - use configured finisher identifiers for translations

Ralf Zimmermann CR +2 V +2 Easy +15 −3 updated 09/11/17, 17:34

Commit message

Use the configured finisher identifier for translation keys instead of
the finisher class name.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Denis Mir +1
    • Björn Jacob +1
  • Verified V +2
    • Christian Kuhn +2
    • Denis Mir +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Ralf Zimmermann uploaded patch set 1 06/30/17, 08:13

  2. TYPO3com voted on patch set 1 V +1 06/30/17, 08:24 Completed build in 11m 09s on Fri, 30 Jun, 10:24 AM Test Summary: 56751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12917

  3. Ralf Zimmermann updated the commit message in patch set 2 07/05/17, 08:53

  4. TYPO3com voted on patch set 2 V +1 07/05/17, 09:05 Completed build in 11m 22s on Wed, 5 Jul, 11:05 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13013

  5. Denis Mir commented on patch set 2 CR +1 V +1 08/31/17, 12:37

    Looks good to me. I have tested the bugfix against the master with hour own set of forms and the configured translation keys using the finisher identifier get picked up nicely.
  6. Björn Jacob voted on patch set 2 CR +1 V +1 08/31/17, 13:09

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 08/31/17, 13:10

  8. Gerrit merged patch set 2 08/31/17, 13:10

  9. Christian Kuhn commented on patch set 3 08/31/17, 13:10

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 82a5620694bdbafbc38937e7c3d77d39168268f5
  10. Mathias Brodala commented on patch set 3 09/04/17, 09:30

    This also seems to fix https://forge.typo3.org/issues/82087, thanks. :-)
  11. Frans Saris commented on patch set 3 09/11/17, 17:34

    This breaks all finishers that implement the constructor .... :(