61447[BUGFIX] Fix return type of getFileObjectFromCombinedIdentifier
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oliver Klee +1
- Frank Nägler +1
-
Verified V +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1216
-
Oli Bartsch uploaded patch set 1 08/06/19, 06:37
-
Mathias Brodala commented on patch set 1 08/06/19, 06:44
-
TYPO3com voted on patch set 1 V +1 08/06/19, 06:51 Completed build in 14m 29s on Tue, 6 Aug, 06:51 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35607
-
Frank Nägler uploaded patch set 2 08/06/19, 06:58
-
Oli Bartsch uploaded patch set 3 08/06/19, 06:58
-
Frank Nägler commented on patch set 3 CR -1 08/06/19, 07:00
ResourceFactory.php:398this is a breaking change, since this is public API. Please remove the type hint. -
Kevin Ditscheid voted on patch set 3 CR +1 08/06/19, 07:01
-
TYPO3com voted on patch set 2 V +1 08/06/19, 07:10 Completed build in 12m 01s on Tue, 6 Aug, 07:10 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35608
-
TYPO3com voted on patch set 3 V +1 08/06/19, 07:11 Completed build in 12m 07s on Tue, 6 Aug, 07:11 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35609
-
Oli Bartsch uploaded patch set 4 08/06/19, 07:13
-
Oli Bartsch commented on patch set 4 08/06/19, 07:15
ResourceFactory.php:395ReplyYou are totally right. Changed it.ResourceFactory.php:398ReplyThank you to point me on that. Removed the type hint and changed the commit message accordingly. -
TYPO3com voted on patch set 4 V +1 08/06/19, 07:23 Completed build in 09m 49s on Tue, 6 Aug, 07:23 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35610
-
Oliver Klee voted on patch set 4 CR +1 08/06/19, 08:55
-
Frank Nägler voted on patch set 4 V +1 CR +1 08/06/19, 11:32
-
Andreas Kienast voted on patch set 4 V +2 CR +2 08/06/19, 12:13
-
Andreas Kienast merged patch set 5 08/06/19, 12:14
ResourceFactory.php:395