#88924Wrong return hint for ResourceFactory getFileObjectFromCombinedIdentifier
Description
The return type hint for the function `getFileObjectFromCombinedIdentifier` in the `ResourceFactory` is wrong, because the underlying function `getFileObjectByStorageAndIdentifier` can also return `NULL` or `ProcessedFile`.
https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/core/Classes/Resource/ResourceFactory.php#L395
Reviews 2
History 27
-
Gerrit Code Review pushed patch set 1 for master to change 61447 status
NewUnder Review 08/06/19, 08:37 -
Gerrit Code Review pushed patch set 2 for master to change 61447 08/06/19, 08:58
-
Gerrit Code Review pushed patch set 3 for master to change 61447 08/06/19, 08:59
-
Gerrit Code Review pushed patch set 4 for master to change 61447 08/06/19, 09:13
-
Gerrit Code Review pushed patch set 1 for 9.5 to change 61370 08/06/19, 14:14
-
Oliver Bartsch commented and changed status
Under ReviewResolved done0 %100 % 08/06/19, 14:30 -
Benni Mack changed status
ResolvedClosed 12/23/19, 22:50
Applied in changeset commit:c2e235de0982f627f1c43b466d8df868ad9369eb.