Review TYPO3_8-7 Merged

61458[TASK] Make Redis connectors compatible with PHP redis version 5

Frank Nägler CR +2 V +2 Easy +18 −18 updated 08/07/19, 16:17

Commit message

Version 5 of phpredis deprecates some methods, which have not been
aligned to the official redis commands.
This patch replaces all calls to use the correct methods.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 812

  1. Frank Nägler commented on patch set 1 08/07/19, 15:24

    Cherry Picked from branch 9.5. The following files contain Git conflicts: * typo3/sysext/core/Classes/Cache/Backend/RedisBackend.php * typo3/sysext/core/Tests/Functional/Cache/Backend/RedisBackendTest.php
  2. Frank Nägler uploaded patch set 2 08/07/19, 15:26

  3. Frank Nägler uploaded patch set 3 08/07/19, 15:27

  4. TYPO3com voted on patch set 2 V -1 08/07/19, 15:28 Completed build in 42s on Wed, 7 Aug, 03:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3590

  5. TYPO3com voted on patch set 1 V -1 08/07/19, 15:28 Completed build in 55s on Wed, 7 Aug, 03:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3589

  6. TYPO3com voted on patch set 3 V -1 08/07/19, 15:28 Completed build in 31s on Wed, 7 Aug, 03:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3591

  7. Frank Nägler uploaded patch set 4 08/07/19, 15:30

  8. Frank Nägler commented on patch set 4 08/07/19, 15:32

    This change is ready for review.
  9. TYPO3com voted on patch set 4 V +1 08/07/19, 15:59 Completed build in 24m 18s on Wed, 7 Aug, 03:59 PM Test Summary: 80366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3592

  10. Oliver Klee voted on patch set 4 CR +1 08/07/19, 16:00

  11. Frank Nägler voted on patch set 4 V +2 CR +2 08/07/19, 16:16

  12. Frank Nägler merged patch set 5 08/07/19, 16:17