Issue Bug Closed

#88701usage of deprecated methods of PHP Redis library since version 5.0.0

Hannes Bochmann 07/08/19, 11:09 updated 12/23/19, 22:49

Description

The method $this->redis->multi(…)->sRemove() in RedisBackend.php is deprecated since PHPRedis 5.0.0. Haven’t checked yet if other methods are affected, too.

Reviews 3

History 514

  1. Markus Klein commented and changed status New Accepted TYPO3 Version 10 8 07/12/19, 10:52

    Yes, Redis::delete().

    We should make the core compatible with both versions of the redis-extension.

    https://pecl.php.net/package/redis

  2. Markus Klein commented 07/12/19, 11:14

    Regex to search for all deprecated functions according to the git changelog of phpredis

    (delete|evaluate|evaluateSha|getKeys|getMultiple|lGet|lGetRange|lRemove|lSize|listTrim|open|popen|renameKey|sContains|sGetMembers|sRemove|sSize|sendEcho|setTimeout|substr|zDelete|zDeleteRangeByRank|zDeleteRangeByScore|zInter|zRemove|zRemoveRangeByScore|zReverseRange|zSize|zUnion)\(

  3. Gerrit Code Review pushed patch set 1 for master to change 61277 status Accepted Under Review 07/12/19, 11:14

  4. Gerrit Code Review pushed patch set 2 for master to change 61277 07/12/19, 12:25

  5. Gerrit Code Review pushed patch set 3 for master to change 61277 07/22/19, 00:40

  6. Gerrit Code Review pushed patch set 4 for master to change 61277 08/07/19, 15:53

  7. Gerrit Code Review pushed patch set 1 for 9.5 to change 61457 08/07/19, 17:24

  8. Gerrit Code Review pushed patch set 1 for TYPO3_8-7 to change 61458 08/07/19, 17:24

  9. Gerrit Code Review pushed patch set 2 for TYPO3_8-7 to change 61458 08/07/19, 17:26

  10. Gerrit Code Review pushed patch set 3 for TYPO3_8-7 to change 61458 08/07/19, 17:27

  11. Markus Klein commented and changed status Under Review Resolved done 0 % 100 % 08/07/19, 17:30

    Applied in changeset commit:f8189917d17058e0802e5381f4cb5fb52b9ff662.

  12. Gerrit Code Review pushed patch set 4 for TYPO3_8-7 to change 61458 status Resolved Under Review 08/07/19, 17:30

  13. Markus Klein commented and changed status Under Review Resolved 08/07/19, 18:30

    Applied in changeset commit:ea2454282296dc5177b02c53812535b5ec39554e.

  14. Benni Mack changed status Resolved Closed 12/23/19, 22:49