Review main Merged

61868[BUGFIX] Adjust visibility of IRRE controls

Andreas Kienast CR +2 V +2 Easy +5 −5 updated 10/01/19, 07:53

Commit message

Previously, if constraints in an IRRE container were met, the control
container's visibility has been toggled. However, the PHP backend
defines the visibility per control item.

The JavaScript now toggles the visibility per control as well and does
not hide the container anymore.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 10/01/19, 06:45

  2. Andreas Kienast updated the commit message in patch set 2 10/01/19, 06:45

  3. TYPO3com voted on patch set 1 V +1 10/01/19, 06:58 Completed build in 13m 02s on Tue, 1 Oct, 06:58 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36976

  4. TYPO3com voted on patch set 2 V +1 10/01/19, 07:06 Completed build in 20m 20s on Tue, 1 Oct, 07:06 AM Test Summary: 47758 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36977

  5. Oliver Hader voted on patch set 2 V +1 CR +1 10/01/19, 07:06

  6. Oliver Hader voted on patch set 2 V +2 CR +2 10/01/19, 07:52

  7. Oliver Hader merged patch set 3 10/01/19, 07:52

  8. Tobi Kretschmann voted on patch set 2 V +1 CR +1 10/01/19, 07:53