Review 9.5 Merged

62908[BUGFIX] Check isAbsPath when creating log file

Benni Mack CR +2 V +2 Easy +1 −1 updated 01/15/20, 15:25

Commit message

As Windows uses for example "D:" as path prefix
the log file writer fails to recognize it as valid
local file path and skips creation of the log file.
To allow usage on Windows, isAbsPath is now used to
check the file path - if it is a valid absPath it
is handled in the same way as all other local files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Benni Mack commented on patch set 1 01/15/20, 14:01

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 01/15/20, 14:25 Completed build in 23m 55s on Wed, 15 Jan, 02:25 PM Test Summary: 73094 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1836

  3. TYPO3com voted on patch set 1 V +1 01/15/20, 14:59 Completed build in 1h 21m 33s on Wed, 15 Jan, 02:59 PM Test Summary: 73094 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1836

  4. Benni Mack voted on patch set 1 V +2 CR +2 01/15/20, 15:25

  5. Benni Mack merged patch set 2 01/15/20, 15:25