Review main Merged

62914[BUGFIX] Check isAbsPath when creating log file

Susi Moog CR +2 V +2 Easy +1 −1 updated 01/15/20, 14:00

Commit message

As Windows uses for example "D:" as path prefix
the log file writer fails to recognize it as valid
local file path and skips creation of the log file.
To allow usage on Windows, isAbsPath is now used to
check the file path - if it is a valid absPath it
is handled in the same way as all other local files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Susi Moog uploaded patch set 1 01/15/20, 13:31

  2. Markus Klein updated the commit message in patch set 2 01/15/20, 13:33

  3. Markus Klein voted on patch set 2 V +1 CR +1 01/15/20, 13:39

  4. TYPO3com voted on patch set 1 V +1 01/15/20, 13:46 Completed build in 14m 19s on Wed, 15 Jan, 01:46 PM Test Summary: 69527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39971

  5. TYPO3com voted on patch set 2 V +1 01/15/20, 13:49 Completed build in 11m 00s on Wed, 15 Jan, 01:49 PM Test Summary: 69527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39972

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/15/20, 14:00

  7. Benni Mack merged patch set 3 01/15/20, 14:00