Review main Merged

63792[TASK] Render edit popup of SelectMultipleSideBySide at intuitive place

Susi Moog CR +2 V +2 Easy +37 −2 updated 03/21/20, 09:52

Commit message

When using the edit popup of SelectMultipleSideBySide editing is related
to the items that are active and selected in the element. The old
placement of the edit pencil however suggested that it should be
possible to edit all (even inactive items, unrelated to the current
record) elements. Whenever an editPopup is configured to be shown in
a SelectMultipleSideBySide element, the edit pencil is now placed
directly next to the active select items.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Susi Moog uploaded patch set 1 03/19/20, 10:21

  2. TYPO3com voted on patch set 1 V -1 03/19/20, 10:39 Completed build in 17m 39s on Thu, 19 Mar, 10:39 AM Test Summary: 71792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1439

  3. TYPO3com voted on patch set 1 V +1 03/19/20, 10:51 Completed build in 47m 21s on Thu, 19 Mar, 10:51 AM Test Summary: 72084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1439

  4. Sybille Peters voted on patch set 1 V +1 03/19/20, 14:30

  5. Susi Moog commented on patch set 1 03/20/20, 06:01

    though the solution is quite hacky, I did not manage to come up with a cleaner one that still works with the API we currently have.
  6. Anja Leichsenring voted on patch set 1 V +1 CR +1 03/21/20, 08:56

  7. Andreas Kienast commented on patch set 1 CR -1 03/21/20, 09:03

    I'm checking something
  8. Andreas Kienast uploaded patch set 2 03/21/20, 09:07

  9. Andreas Kienast voted on patch set 2 V +1 CR +1 03/21/20, 09:07

  10. TYPO3com voted on patch set 2 V +1 03/21/20, 09:50 Completed build in 36m 52s on Sat, 21 Mar, 09:50 AM Test Summary: 72165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1531

  11. Anja Leichsenring voted on patch set 2 V +2 CR +2 03/21/20, 09:52

  12. Anja Leichsenring merged patch set 3 03/21/20, 09:52