Issue Bug Closed

#90777Trying to edit an existing file mount in BE group form results in error

Sybille Peters 03/18/20, 12:40 updated 04/01/20, 21:15

Description

The question is: How to edit (existing) file mount in be groups form in BE?
I don’t know how to do it. If there is a way to do it, perhaps there is a way to make this more intuitive.

Reproduce

  1. Open form for editing a group
  2. There are some existing file mounts in the list of “Available items”
  3. There is (AFAIK) no way to select one without moving it to the list “Selected items”, but selecting it and then removing it again supposedly make it selected in the list “Available Items”
  4. click the pencil “Edit filemount”

Actual outcome

Even if an item is selected, clicking on the edit pencil yields:

“Please select one or more items in the list before you can edit.”

filemount.png

Expected outcome

The edit pencil “Edit filemount” should edit the selected item

Reviews 1

Files 2

History 57

  1. Susanne Moog commented and changed status New Accepted 03/19/20, 10:52

    I think the expected behaviour should be different, however I agree that we have a UI problem here:

    It’s totally fine IMHO that the edit pencil only allows editing of active items in this context, as it doesn’t make much sense to go through the length of opening this group record to edit an unrelated group – and in fact is the source of the problem here, as the data is taken from the active records field with that value. —> Selecting it by first selecting than unselecting is also kind of awkward.

    However the placement of the pencil on the right of the field does suggest the editing of all records and should probably be moved.

    step1.png

  2. Gerrit Code Review pushed patch set 1 for master to change 63792 status Accepted Under Review 03/19/20, 11:21

  3. Susanne Moog changed attached step1.png 03/19/20, 11:23

  4. Sybille Peters commented 03/19/20, 15:24

    Yes, I agree. Removing the pencil would be sufficient. There are other places to edit the filemounts (e.g. on page 0).

  5. Gerrit Code Review pushed patch set 2 for master to change 63792 03/21/20, 10:07

  6. Susanne Moog commented and changed status Under Review Resolved done 0 % 100 % 03/21/20, 11:00

    Applied in changeset commit:3503dfae0127347ca4219eb91b1ca06c1668c5ac.

  7. Benni Mack changed status Resolved Closed 04/01/20, 21:15