Review 10.4 Merged

66917[BUGFIX] Allow removal of RegularExpression validator

Daniel Goerz CR +2 V +2 Easy +6 −0 updated 11/27/20, 09:51

Commit message

Add the missing "delete" button to the RegularExpression
validator for form elements "Telephone" and "Url", allowing
to remove a previously manually added validator again.

Note: The "Email" and "Number" form elements do both also
include validators which are missing the "delete" button. But
since this validators (email validator respectively number
validator) are added automatically on form element creation,
it's considered intended behaviour. Only validators which were
added manually must provide the option to delete them again.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Daniel Goerz commented on patch set 1 11/27/20, 08:22

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 11/27/20, 08:35 Completed build in 12m 41s on Fri, 27 Nov, 08:35 AM Test Summary: 75183 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-844

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 11/27/20, 09:51

  4. Daniel Goerz merged patch set 2 11/27/20, 09:51