Review 10.4 Merged

66918[BUGFIX] Do not hand invalid input to ResourceFactory

Benni Mack CR +2 V +2 Easy +4 −0 updated 11/27/20, 10:22

Commit message

A phpstan related patch revealed a flaw in EXT:form
PropertyMappingConfiguration when an "EXT:" path was
passed to the FAL ResourceFactory.

Instead of relying on the InvalidArgumentException
this patch now prevents the invalid argument from being
passed in the first place.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 11/27/20, 08:28

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 11/27/20, 08:40 Completed build in 11m 07s on Fri, 27 Nov, 08:39 AM Test Summary: 75183 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-845

  3. Benni Mack voted on patch set 1 V +2 CR +2 11/27/20, 10:22

  4. Benni Mack merged patch set 2 11/27/20, 10:22