Review 10.4 Merged

67012[BUGFIX] Ensure pageUid of RedirectFinisher can be parsed correctly

Daniel Goerz CR +2 V +2 Normal +119 −2 updated 12/05/20, 09:41

Commit message

With #92112, parsing of the pageUid option of the RedirectFinisher has
been restricted to accept only strings as option value. Prior to this
change, one could also define integer values. The previous behavior has
now been restored by explicitly parsing the option value as string and
then parsing it back to an integer.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 46

  1. Daniel Goerz commented on patch set 1 12/04/20, 15:01

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 12/04/20, 15:13 Completed build in 11m 53s on Fri, 4 Dec, 03:13 PM Test Summary: 30 of 75728 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-873

  3. Elias Häußler uploaded patch set 2 12/04/20, 15:45

  4. TYPO3com voted on patch set 2 V +1 12/04/20, 15:59 Completed build in 13m 51s on Fri, 4 Dec, 03:59 PM Test Summary: 75243 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-874

  5. Daniel Goerz voted on patch set 2 V +2 CR +2 12/05/20, 09:41

  6. Daniel Goerz merged patch set 3 12/05/20, 09:41