67055[TASK] Change page unavailable status code from 500 to 503
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- TYPO3com +1 CI
Issues 1
Files 2
Review log 812
-
Benni Mack commented on patch set 1 12/09/20, 14:28
Cherry Picked from branch master. -
TYPO3com voted on patch set 1 V +1 12/09/20, 14:42 Completed build in 13m 50s on Wed, 9 Dec, 02:42 PM Test Summary: 75237 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-891
-
Benjamin Franzke commented on patch set 1 CR -1 12/09/20, 15:04
ErrorController.php:53As already mentioned in the master patch, I'd like to fallback to 500 for v10 when no 503 handler is defined. Therefore -1 for now. -
Benjamin Franzke uploaded patch set 2 12/10/20, 05:48
-
Benjamin Franzke commented on patch set 2 V -1 12/10/20, 05:52
Hm.. This currently doesn't even work for overwriting the 503 error handler with an own one :\ typo3/cms-frontend/maintenance-mode is executed before typo3/cms-frontend/site, therefore site configuration will never be found, and the configured handler isn't executed. Doesn't matter whether it's 500 or 503. Seems we need to add a followup to this one, by adding typo3/cms-frontend/maintenance-mode.after[] = typo3/cms-frontend/site to frontend RequestMiddlewares.php This also applies to the master patch. (I mean, still, sending 503 is still good, it's just the error handling overwrites that doesn't kick in). -
TYPO3com voted on patch set 2 V -1 12/10/20, 06:50 Completed build in 1h 01m 54s on Thu, 10 Dec, 06:50 AM Test Summary: 75121 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-892
-
Benjamin Franzke uploaded patch set 3 12/10/20, 07:22
-
Benjamin Franzke commented on patch set 3 V +1 CR +1 12/10/20, 07:27
ErrorController.php:53Reply UnresolvedSince both 500 and 503 where not handled by custom error handlers in maintenace middlewre I'd say we go ahead with 503 only and streamline error handling for both, master and 10.4 in another patch. Therefore I've reverted to patchset 1 now. But I'd like to adapt the 5xx cases a bit. We've got 503 for maintenace mode now, that is fine. But for PageAccessFailureReasons::ACCESS_DENIED_GENERAL and PageAccessFailureReasons::ROOTLINE_BROKEN the unavailableAction is used as well, and in that case a 500 error would be the appropriate one. unavailableAction really sounds like 503 and therefore it's fine for this patch to change that to 503. Therefore I'd fix TSFE to call a new `errorAction` that responds with 500. Will take care of that in a new patch. Please let me know if you'd rather like to see this reverted anyway(?) IMO this can be merged and streamlined in a follow up. -
TYPO3com voted on patch set 3 V -1 12/10/20, 07:34 Completed build in 12m 00s on Thu, 10 Dec, 07:34 AM Test Summary: 74252 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-893
-
TYPO3com voted on patch set 3 V +1 12/10/20, 07:59 Completed build in 10m 57s on Thu, 10 Dec, 07:59 AM Test Summary: 75237 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-895
-
Benjamin Franzke voted on patch set 3 V +2 CR +2 12/10/20, 08:36
-
Benjamin Franzke merged patch set 4 12/10/20, 08:36