Review 10.4 Merged

67292[BUGFIX] Re-validate changed fields only

Richard Haeser CR +2 V +2 Normal +74 −50 updated 12/31/20, 08:58

Commit message

Probably since ever, FormEngine validates the whole form when a field
changed or an IRRE item got removed. This patch introduces the following
changes:

- only fields affected by the `change` event get validated
- FormEngineValidation.validate() accepts an optional argument to define
  the container whose fields get validated. If omitted, the whole form
  is validated.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 57

  1. Richard Haeser commented on patch set 1 12/29/20, 15:23

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/InputDateTimeElement.ts * Build/types/TYPO3/index.d.ts * typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/InlineControlContainer.js * typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/InputDateTimeElement.js
  2. TYPO3com voted on patch set 1 V -1 12/29/20, 15:35 Completed build in 12m 02s on Tue, 29 Dec, 03:35 PM Test Summary: 25 of 75759 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-939

  3. Andreas Kienast uploaded patch set 2 12/31/20, 08:23

  4. TYPO3com voted on patch set 2 V +1 12/31/20, 08:35 Completed build in 11m 40s on Thu, 31 Dec, 08:35 AM Test Summary: 75274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-941

  5. Richard Haeser commented on patch set 2 12/31/20, 08:35

    This change is ready for review.
  6. Richard Haeser voted on patch set 2 V +2 CR +2 12/31/20, 08:58

  7. Richard Haeser merged patch set 3 12/31/20, 08:58