Review 10.4 Merged

67295[BUGFIX] Do not call "libxml_disable_entity_loader" in PHP 8

Benjamin Franzke CR +2 V +2 Normal +83 −25 updated 01/04/21, 08:26

Commit message

Because the method (finally) is deprecated in PHP 8,
all calls in TYPO3 Core are wrapped in if statements
to avoid deprecation warnings.

PHP 8 effectively is more secure by default,
which is a good thing, but we need to consider this
in our code base, which still supports PHP 7
as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 46

  1. Benjamin Franzke commented on patch set 1 01/04/21, 08:03

    Cherry Picked from branch master.
  2. Benjamin Franzke uploaded patch set 2 01/04/21, 08:08

  3. TYPO3com voted on patch set 1 V +1 01/04/21, 08:16 Completed build in 13m 16s on Mon, 4 Jan, 08:16 AM Test Summary: 75272 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-945

  4. TYPO3com voted on patch set 2 V +1 01/04/21, 08:22 Completed build in 13m 25s on Mon, 4 Jan, 08:22 AM Test Summary: 75274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-946

  5. Benni Mack voted on patch set 2 V +2 CR +2 01/04/21, 08:26

  6. Benni Mack merged patch set 3 01/04/21, 08:26