67296[TASK] Make first install compatible with PHP 8
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 8
- Build/Scripts/duplicateExceptionCodeCheck.sh+1 −0
- typo3/sysext/backend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+0 −1
- typo3/sysext/core/Classes/Database/Driver/PDOStatement.php+6 −18
- typo3/sysext/core/Classes/Database/Driver/PDOStatementImplementation.phpnew+64 −0
- typo3/sysext/core/Classes/Error/ErrorHandler.php+3 −5
- typo3/sysext/frontend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php+1 −1
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+8 −3
- phpstan.neon+3 −0
Review log 1823
-
Benjamin Franzke commented on patch set 1 01/04/21, 09:26
Cherry Picked from branch master. -
Benjamin Franzke commented on patch set 1 V -1 01/04/21, 09:38
In install step 4 => 5: <b>Fatal error</b>: Declaration of Doctrine\DBAL\Driver\PDOConnection::query() must be compatible with PDO::query(string $query, ?int $fetchMode = null, mixed ...$fetchModeArgs) in <b>[…]/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php</b> on line <b>81</b><br /> -
TYPO3com voted on patch set 1 V -1 01/04/21, 09:41 Completed build in 14m 55s on Mon, 4 Jan, 09:41 AM Test Summary: 1 of 75759 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-947
-
Benjamin Franzke commented on patch set 1 CR -1 01/04/21, 18:41
Backport on hold. Needs to wait for a php 7.2-8.x compatible doctrine/dbal v2.x release. -
Jörn Wagner commented on patch set 1 01/05/21, 09:19
Reply
This would mean cherry-picking https://review.typo3.org/c/Packages/TYPO3.CMS/+/66971 into 10.4, right? -
Benjamin Franzke commented on patch set 1 01/05/21, 11:16
Reply
No, unfortunately not, as doctrine/dbal 2.12 does not support PHP 7.2, which we need for v10. Therefore we need to wait for another 2.12.x/2.13 release which re-adds PHP 7.2 support. (Benni talked to the doctrine/dbal developers and they promised to release one) -
Benni Mack rebased onto patch set 2 05/11/21, 19:08
-
core-ci voted on patch set 2 V -1 05/11/21, 19:26 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11396
-
Benni Mack uploaded patch set 3 05/11/21, 20:05
-
core-ci voted on patch set 3 V -1 05/11/21, 20:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11406
-
Benni Mack uploaded patch set 4 05/11/21, 20:30
-
core-ci voted on patch set 4 V +1 05/11/21, 20:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11409
-
Benni Mack commented on patch set 4 CR +1 05/11/21, 20:44
Fine with me now. (we can now add this because we also have Doctrine DBAL 2.13 support) -
Benjamin Franzke uploaded patch set 5 05/26/21, 04:42
-
Benjamin Franzke voted on patch set 5 V 0 CR 0 05/26/21, 04:44
-
Benjamin Franzke commented on patch set 5 05/26/21, 04:47
Sorry, pushed old patchset by accident. Will revert to patchset 4 (as pushed by Benni). -
Benjamin Franzke uploaded patch set 6 05/26/21, 04:48
-
core-ci voted on patch set 6 V +1 05/26/21, 04:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11861
-
Benjamin Franzke commented on patch set 6 V -1 05/26/21, 05:00
Hm.. I still get an error during installation in install[action]: executeDatabaseData PHP Fatal error: Declaration of Doctrine\DBAL\Driver\PDOConnection::query() must be compatible with PDO::query(string $query, ?int $fetchMode = null, mixed ...$fetchModeArgs) in /home/ben/src/TYPO310.CMS/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php on line 81 [Wed May 26 06:56:04 2021] 127.0.0.1:33506 [200]: POST /typo3/install.php - Declaration of Doctrine\DBAL\Driver\PDOConnection::query() must be compatible with PDO::query(string $query, ?int $fetchMode = null, mixed ...$fetchModeArgs) in /home/ben/src/TYPO310.CMS/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php on line 81 [Wed May 26 06:56:04 2021] 127.0.0.1:33506 Closing -
Benjamin Franzke commented on patch set 6 05/26/21, 05:02
Also @benni, should we adapt typo3/sysext/install/Resources/Private/Php/install.php to allow PHP 8.0? Or better to that later (if at all) together with all entry points? -
Benni Mack commented on patch set 6 05/27/21, 20:32
will also test this one the next few days.Reply
we should do that later. -
Benjamin Franzke marked it work in progress 09/16/21, 23:29
-
Christian Kuhn abandoned the change 12/23/21, 11:45
I think we can safely abandon this one: v10 will not see php 8 compatibility.