Review 10.4 Merged

67307[BUGFIX] Fix requirejs-loader config and error handling

Benjamin Franzke CR +2 V +2 Easy +11 −5 updated 01/06/21, 13:41

Commit message

Adapt the fetch-configuration URL query string, to account for the
backend url change in #93048, in order to use a questionmark
to concatenate the query string instead of an ampersand.
But allow for both, base URLs with and without question mark,
as frontend context via eID would still require an ampersand
for concatenation.

Also fix a error callback name clash and properly propagate
fetchConfiguration errors through the requirejs error handling,
for requirejs errbacks to be invoked.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 01/06/21, 13:08

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/06/21, 13:23 Completed build in 15m 02s on Wed, 6 Jan, 01:23 PM Test Summary: 75280 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-966

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 01/06/21, 13:41

  4. Benjamin Franzke merged patch set 2 01/06/21, 13:41