Review 10.4 Merged

67311[BUGFIX] Suppress warning in SimpleFileBackend unlink()

Benjamin Franzke CR +2 V +2 Easy +1 −6 updated 01/07/21, 15:19

Commit message

Calling $cache->remove() on a simple file backend when
the file does not exist leads to a PHP warning.
Checking with file_exists() before could lead to race
conditions if some other process unlinks in between.
Solution is to simply suppress the unlink warning.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 01/07/21, 15:06

    Cherry Picked from branch master.
  2. Benjamin Franzke voted on patch set 1 V +2 CR +2 01/07/21, 15:07

  3. TYPO3com voted on patch set 1 V +1 01/07/21, 15:19 Completed build in 12m 45s on Thu, 7 Jan, 03:19 PM Test Summary: 75304 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-971

  4. Benjamin Franzke merged patch set 2 01/07/21, 15:19