Review 10.4 Merged

67372[BUGFIX] Working preview links in workspace mails

Christian Kuhn CR +2 V +2 Easy +13 −17 updated 01/10/21, 11:50

Commit message

Fix a couple of issues with state change emails in
workspaces:

* We still can't deep link to the backend. The generated
  comparisonLink to the side-by-side preview module is a
  workspace backend functionality. The generated links
  don't work and show the login form. The fix is to
  generate "preview links" instead which call a frontend.
  We may be able to improve this later, when core v11
  allows deep linking.

* When changing the stage of a page delete placeholder
  - when a page is for deletion in live - preview link
  generation to these pages does not make sense, trying
  to generate such a link throws an exception "no
  connection to page tree", the ajax request fails and
  no mails are send. Fix is to catch the exception and
  leave out the link in the emails.

* Preview links did not carry the language id when
  sending notifications for state changes of non default
  language records. This is added to properly link to
  non-default language previews.

* A missing closing p-tag in the HTML mail.

* As a better default, preview links are now always added
  to the mails if possible. In rare cases where this is
  not wanted, the mail templates should be adapted.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 3

Files 5

Review log 67

  1. Christian Kuhn commented on patch set 1 01/07/21, 18:47

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/07/21, 19:01 Completed build in 13m 49s on Thu, 7 Jan, 07:01 PM Test Summary: 75304 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-972

  3. Richard Haeser voted on patch set 1 CR +1 01/09/21, 09:19

  4. Richard Haeser commented on patch set 1 CR 0 01/09/21, 09:23

    StageChangeNotification.php:92

    Is the removal of the comparisonView link something we need to specify in RST / commit message? And for my information (didn't look too much into it), why do we remove this link?
  5. Christian Kuhn commented on patch set 1 01/10/21, 11:50

    StageChangeNotification.php:92 Reply Unresolved

    The comparisonLink is broken - we currently can't create a deep link to a backend interface for a different user. This may change for v11, but we need a bugfix for v10 and v11 for now. This is why i 'activated' the previewLink instead. I don't think this requires a .rst file.
  6. Christian Kuhn voted on patch set 1 V +2 CR +2 01/10/21, 11:50

  7. Christian Kuhn merged patch set 2 01/10/21, 11:50