67372[BUGFIX] Working preview links in workspace mails
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
-
Verified V +2 Done
- Christian Kuhn +2
- TYPO3com +1 CI
Issues 3
Files 5
- typo3/sysext/core/Documentation/Changelog/10.3/Feature-90411-HTML-basedWorkspaceNotificationEmailsOnStageChange.rst+0 −5
- typo3/sysext/workspaces/Classes/Notification/StageChangeNotification.php2+12 −6
- typo3/sysext/workspaces/Resources/Private/Templates/Email/StageChangeNotification.html+1 −4
- typo3/sysext/workspaces/Resources/Private/Templates/Email/StageChangeNotification.txt+0 −1
- typo3/sysext/workspaces/ext_localconf.php+0 −1
Review log 67
-
Christian Kuhn commented on patch set 1 01/07/21, 18:47
Cherry Picked from branch master. -
TYPO3com voted on patch set 1 V +1 01/07/21, 19:01 Completed build in 13m 49s on Thu, 7 Jan, 07:01 PM Test Summary: 75304 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-972
-
Richard Haeser voted on patch set 1 CR +1 01/09/21, 09:19
-
Richard Haeser commented on patch set 1 CR 0 01/09/21, 09:23
StageChangeNotification.php:92Is the removal of the comparisonView link something we need to specify in RST / commit message? And for my information (didn't look too much into it), why do we remove this link? -
Christian Kuhn commented on patch set 1 01/10/21, 11:50
StageChangeNotification.php:92Reply UnresolvedThe comparisonLink is broken - we currently can't create a deep link to a backend interface for a different user. This may change for v11, but we need a bugfix for v10 and v11 for now. This is why i 'activated' the previewLink instead. I don't think this requires a .rst file. -
Christian Kuhn voted on patch set 1 V +2 CR +2 01/10/21, 11:50
-
Christian Kuhn merged patch set 2 01/10/21, 11:50