Review 10.4 Merged

67473[BUGFIX] Assure page title editing when creating new pages

Richard Haeser CR +2 V +2 Hard +276 −2 updated 01/16/21, 15:57

Commit message

Using drag and drop, one can create new pages within the
page tree. New pages can be created before, after or
within existing pages. Currently, one could not provide
a page title if the page was created within a page
without subpages due to issues with unintended focus
change after drag and drop.

It is now ensured that a page title can be edited
directly after dragging a page into the page tree. Some
cases are also covered by acceptance tests now.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 812

  1. Richard Haeser commented on patch set 1 01/16/21, 13:18

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTree.js
  2. TYPO3com voted on patch set 1 V -1 01/16/21, 13:19 Completed build in 26s on Sat, 16 Jan, 01:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-987

  3. Richard Haeser uploaded patch set 2 01/16/21, 15:26

  4. Richard Haeser commented on patch set 1 01/16/21, 15:26

    This change is ready for review.
  5. Richard Haeser marked it ready for review 01/16/21, 15:26

  6. TYPO3com voted on patch set 2 V -1 01/16/21, 15:26 Completed build in 23s on Sat, 16 Jan, 03:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-988

  7. Richard Haeser uploaded patch set 3 01/16/21, 15:30

  8. TYPO3com voted on patch set 3 V -1 01/16/21, 15:31 Completed build in 32s on Sat, 16 Jan, 03:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-989

  9. Richard Haeser uploaded patch set 4 01/16/21, 15:44

  10. TYPO3com voted on patch set 4 V +1 01/16/21, 15:56 Completed build in 12m 08s on Sat, 16 Jan, 03:56 PM Test Summary: 75314 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-990

  11. Richard Haeser voted on patch set 4 V +2 CR +2 01/16/21, 15:57

  12. Richard Haeser merged patch set 5 01/16/21, 15:57