67478[TASK] Use buttons in Permissions module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 6
- Build/Sources/TypeScript/beuser/Resources/Public/TypeScript/Permissions.ts+9 −7
- typo3/sysext/beuser/Classes/Controller/PermissionAjaxController.php+16 −16
- typo3/sysext/beuser/Resources/Private/Partials/Permission/Groupname.html+4 −3
- typo3/sysext/beuser/Resources/Private/Partials/Permission/Ownername.html+4 −3
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.html+6 −4
- typo3/sysext/beuser/Resources/Public/JavaScript/Permissions.js+1 −1
Review log 68
-
Benni Mack commented on patch set 1 01/20/21, 21:10
Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/beuser/Resources/Public/TypeScript/Permissions.ts * typo3/sysext/beuser/Resources/Public/JavaScript/Permissions.js -
TYPO3com voted on patch set 1 V -1 01/20/21, 21:25 Completed build in 12m 08s on Wed, 20 Jan, 09:25 PM Test Summary: 75356 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1001
-
Oli Bartsch uploaded patch set 2 01/21/21, 09:43
-
Oli Bartsch voted on patch set 2 V +1 CR +1 01/21/21, 09:51
-
TYPO3com voted on patch set 2 V +1 01/21/21, 09:57 Completed build in 13m 12s on Thu, 21 Jan, 09:57 AM Test Summary: 75356 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1003
-
Benni Mack marked it ready for review 01/21/21, 11:04
-
Benni Mack voted on patch set 2 V +2 CR +2 01/21/21, 20:36
-
Benni Mack merged patch set 3 01/21/21, 20:36