Review 10.4 Merged

67478[TASK] Use buttons in Permissions module

Benni Mack CR +2 V +2 Normal +40 −34 updated 01/21/21, 20:36

Commit message

The permissions module previously used a lot of
anchor elements without a target defined.

To improve accessibility and semantic correctness
these selectors are now changed to button tags.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 68

  1. Benni Mack commented on patch set 1 01/20/21, 21:10

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/beuser/Resources/Public/TypeScript/Permissions.ts * typo3/sysext/beuser/Resources/Public/JavaScript/Permissions.js
  2. TYPO3com voted on patch set 1 V -1 01/20/21, 21:25 Completed build in 12m 08s on Wed, 20 Jan, 09:25 PM Test Summary: 75356 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1001

  3. Oli Bartsch uploaded patch set 2 01/21/21, 09:43

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 01/21/21, 09:51

  5. TYPO3com voted on patch set 2 V +1 01/21/21, 09:57 Completed build in 13m 12s on Thu, 21 Jan, 09:57 AM Test Summary: 75356 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1003

  6. Benni Mack marked it ready for review 01/21/21, 11:04

  7. Benni Mack voted on patch set 2 V +2 CR +2 01/21/21, 20:36

  8. Benni Mack merged patch set 3 01/21/21, 20:36