Review 10.4 Merged

67486[BUGFIX] Do not render empty title attributes in ImageViewHelper

Daniel Goerz CR +2 V +2 Easy +2 −1 updated 01/29/21, 08:09

Commit message

The ImageViewHelper uses strict types for checking if
the `title` property of the image is not an empty string.
Since this value can also be NULL, a typecast is necessary
for the check to work.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 01/28/21, 18:22

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/28/21, 18:36 Completed build in 14m 25s on Thu, 28 Jan, 06:36 PM Test Summary: 75355 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1020

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 01/29/21, 08:08

  4. Daniel Goerz merged patch set 2 01/29/21, 08:09