Review 10.4 Merged

67503[BUGFIX] Fix redirects to access restricted pages

Oli Bartsch CR +2 V +2 Normal +152 −0 updated 02/10/21, 10:36

Commit message

The RedirectService is using typolink to build links
to the defined target, e.g. a page. In case the redirect
target is an access restricted page and the user is
unauthorized, typolink did not build this link and
therefore the request resulted in a 404 response.

Since unauthorized requests to an access restricted
page should always return a 403 status code, the
`linkAccessRestrictedPages` option is now set in the
typolink configuration. Therefore, the link will be built
even if the user is unauthorized and then redirects to
the target page where the correct 403 status code is
returned.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 714

  1. Oli Bartsch uploaded patch set 1 01/22/21, 08:36

  2. Mathias Brodala commented on patch set 2 01/22/21, 08:41

    Published edit on patch set 1.
  3. Mathias Brodala commented on patch set 2 01/22/21, 08:41

    (Micro edit to add a useful trailing comma.)
  4. TYPO3com voted on patch set 1 V +1 01/22/21, 08:55 Completed build in 13m 57s on Fri, 22 Jan, 08:55 AM Test Summary: 75358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1006

  5. TYPO3com voted on patch set 2 V +1 01/22/21, 09:01 Completed build in 19m 41s on Fri, 22 Jan, 09:01 AM Test Summary: 75359 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1007

  6. Markus Klein voted on patch set 2 CR +1 01/22/21, 13:37

  7. Benjamin Franzke uploaded patch set 3 02/10/21, 10:12

  8. TYPO3com voted on patch set 3 V -1 02/10/21, 10:13 Completed build in 15s on Wed, 10 Feb, 10:13 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1081

  9. core-ci voted on patch set 3 V -1 02/10/21, 10:13 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/577

  10. Benjamin Franzke uploaded patch set 4 02/10/21, 10:21

    Revert to patchset 2
  11. TYPO3com voted on patch set 4 V -1 02/10/21, 10:31 Completed build in 10m 20s on Wed, 10 Feb, 10:31 AM Test Summary: 1 of 75796 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1082

  12. TYPO3com commented on patch set 4 02/10/21, 10:33 Completed build in 22m 20s on Wed, 10 Feb, 10:33 AM Test Summary: 1 of 75796 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1082

  13. TYPO3com voted on patch set 4 V +1 02/10/21, 10:36 Completed build in 37m 17s on Wed, 10 Feb, 10:36 AM Test Summary: 75311 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1082

  14. Benjamin Franzke merged patch set 5 02/10/21, 10:36