Review 10.4 Merged

67592[BUGFIX] Avoid double CSH wraps in linkvalidator tasks settings

Richard Haeser CR +2 V +2 Easy +16 −10 updated 01/31/21, 09:15

Commit message

Labels in linkvalidator's additional field settings for the schedule
are actually invoking `BackendUtility::wrapInHelp` twice - first time
in `ValidatorTaskAdditionalFieldProvider` and second time when actually
rendering with `f:be.labels.csh` view-helper.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Richard Haeser commented on patch set 1 01/31/21, 07:55

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php
  2. TYPO3com voted on patch set 1 V -1 01/31/21, 07:56 Completed build in 24s on Sun, 31 Jan, 07:56 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1021

  3. Richard Haeser uploaded patch set 2 01/31/21, 08:06

  4. Richard Haeser commented on patch set 2 01/31/21, 08:06

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 01/31/21, 08:20 Completed build in 13m 13s on Sun, 31 Jan, 08:20 AM Test Summary: 75356 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1022

  6. Richard Haeser voted on patch set 2 V +2 CR +2 01/31/21, 09:15

  7. Richard Haeser merged patch set 3 01/31/21, 09:15