Review 10.4 Merged

67594[DOCS] Added condition to snippet for social media fallback images

Richard Haeser CR +2 V +2 Easy +2 −0 updated 01/31/21, 15:40

Commit message

It is possible to have multiple og:image meta tags by the specs. By
adding the condition to your TypoScript setup, the fallback images for
social media will only be rendered when no image is set in the page
properties. This will prevent that the fallback image is always
rendered even when an image is set in the backend.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Richard Haeser commented on patch set 1 01/31/21, 15:26

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/31/21, 15:39 Completed build in 12m 12s on Sun, 31 Jan, 03:39 PM Test Summary: 75356 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1023

  3. Richard Haeser voted on patch set 1 V +2 CR +2 01/31/21, 15:40

  4. Richard Haeser merged patch set 2 01/31/21, 15:40