Review 10.4 Merged

67599[BUGFIX] Do not render empty type attribute

Benni Mack CR +2 V +2 Easy +2 −1 updated 02/03/21, 16:34

Commit message

PageRenderer now omits empty type attributes
also for scripts added through includeJSLibs
or includeJSFooterlibs.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 02/03/21, 16:17

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/03/21, 16:26 Completed build in 08m 38s on Wed, 3 Feb, 04:26 PM Test Summary: 75308 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1046

  3. Benni Mack voted on patch set 1 V +2 CR +2 02/03/21, 16:34

  4. Benni Mack merged patch set 2 02/03/21, 16:34