Review 10.4 Merged

67600[TASK] Adapt for upcoming Symfony 5.3 command tag properties

Benjamin Franzke CR +2 V +2 Easy +10 −0 updated 02/04/21, 08:55

Commit message

With the Symfony PR https://github.com/symfony/symfony/pull/39851
new depndency injection console.command tag properties are
supported, which allow to inject the description and
the hidden state into console commands.

In order to maintain a consistent console.command DI tag syntax
between Symfony and TYPO3 core, we now add forward compatibility
for this change.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 02/04/21, 08:44

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/04/21, 08:54 Completed build in 09m 59s on Thu, 4 Feb, 08:54 AM Test Summary: 75308 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1047

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 02/04/21, 08:55

  4. Benjamin Franzke merged patch set 2 02/04/21, 08:55