Review 10.4 Merged

67693[TASK] Replace <style> for compliance with CSP header in svgs

Oliver Hader CR +2 V +2 Easy +8 −8 updated 02/09/21, 20:09

Commit message

SVG with inline styles are not loaded when the Content-Security-Policy
header contains the widely used setting "style-src 'self';" because
the browser has to reject interpreting the style attribute.
In this case a black rectangle is displayed.
Using attributes instead of styles is compliant with CSP "style-src
'self';" and the svgs can be displayed.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Ute Flierl +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Ute Flierl +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Oliver Hader commented on patch set 1 02/09/21, 13:12

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/09/21, 13:23 Completed build in 10m 37s on Tue, 9 Feb, 01:23 PM Test Summary: 75308 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1076

  3. core-ci voted on patch set 1 V +1 02/09/21, 13:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/527

  4. Ute Flierl voted on patch set 1 V +1 CR +1 02/09/21, 13:28

  5. Oliver Hader commented on patch set 1 02/09/21, 14:34

    Reply

    Is the icon copied from TYPO3.Icons package to typo3/sysext/redirects/?
  6. Andreas Kienast commented on patch set 1 CR 0 02/09/21, 15:06

    Reply

    Ha! Good catch, the icons in EXT:redirect aren't the ones of the icon repository.
  7. Richard Haeser voted on patch set 1 V +2 CR +2 02/09/21, 20:09

  8. Richard Haeser merged patch set 2 02/09/21, 20:09