Review 10.4 Merged

67696[BUGFIX] Fix wrong language parameters in language menu shortcut links

Benni Mack CR +2 V +2 Easy +15 −2 updated 02/10/21, 09:51

Commit message

When a shortcut page is used for a translated page, but its parent
is not of type shortcut, the generated link would always use the
current language of the frontend context instead of the actual
required language set in _PAGES_OVERLAY_REQUESTEDLANGUAGE.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 4

Files 3

Review log 35

  1. Benni Mack commented on patch set 1 02/10/21, 09:33

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/10/21, 09:45 Completed build in 11m 16s on Wed, 10 Feb, 09:44 AM Test Summary: 75308 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1078

  3. core-ci voted on patch set 1 V +1 02/10/21, 09:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/573

  4. Richard Haeser voted on patch set 1 V +2 CR +2 02/10/21, 09:51

  5. Richard Haeser merged patch set 2 02/10/21, 09:51