Review 10.4 Merged

67698[BUGFIX] Respect auth mode in page module again

Benjamin Franzke CR +2 V +2 Easy +5 −5 updated 02/10/21, 10:12

Commit message

If a non-admin does not have permissions to access
a specific CType, disallowed via AD mode, the header
icons, e.g. edit or delete, are now no longer displayed
in the page module (fluid based) to prevent error
messages in FormEngine.

Therefore, recordEditAccessInternals is used, which
was also the case in PageLayoutView and actually
already includes the language access check.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Benjamin Franzke commented on patch set 1 02/10/21, 09:58

    Cherry Picked from branch master.
  2. Benjamin Franzke voted on patch set 1 V +2 CR +2 02/10/21, 10:05

  3. TYPO3com voted on patch set 1 V +1 02/10/21, 10:09 Completed build in 09m 55s on Wed, 10 Feb, 10:09 AM Test Summary: 75308 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1080

  4. Benjamin Franzke merged patch set 2 02/10/21, 10:11

  5. core-ci voted on patch set 1 V +1 02/10/21, 10:12 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/576