Review 10.4 Merged

67699[BUGFIX] Never fetch content with delete placeholder

Christian Kuhn CR +2 V +2 Easy +3 −10 updated 02/11/21, 14:19

Commit message

The content fetcher did not consider delete placeholders.
This task was done using a method in GridColumnItem which
was used in the templates directly. Because defLangBinding
is more complex, three additional calls to this method would
be needed.

Since such records shouldn't even be passed to the view at all,
this check is now directly added into the content fetcher. This
means that no elements with a delete placeholder are fetched
anymore, making the getter and the calls in the templates
superfluous. Therefore, the getter along with its single usage
is removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 36

  1. Christian Kuhn commented on patch set 1 02/11/21, 13:34

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/11/21, 13:44 Completed build in 10m 04s on Thu, 11 Feb, 01:44 PM Test Summary: 75311 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1087

  3. core-ci voted on patch set 1 V -1 02/11/21, 13:47 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/643

  4. core-ci voted on patch set 1 V +1 02/11/21, 14:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/643

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 02/11/21, 14:19

  6. Christian Kuhn merged patch set 2 02/11/21, 14:19