Review 10.4 Merged

67932[TASK] Additional tests to check output of TypoScript settings for page titles

Richard Haeser CR +2 V +2 Normal +52 −7 updated 02/15/21, 09:33

Commit message

Verify the output of TypoScript settings config.pageTitleFirst and
config.pageTitleSeparator

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 59

  1. Richard Haeser commented on patch set 1 02/15/21, 09:00

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Tests/Functional/Rendering/TitleTagRenderingTest.php
  2. TYPO3com voted on patch set 1 V -1 02/15/21, 09:01 Completed build in 13s on Mon, 15 Feb, 09:01 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1095

  3. core-ci voted on patch set 1 V -1 02/15/21, 09:02 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/723

  4. Richard Haeser uploaded patch set 2 02/15/21, 09:13

  5. Richard Haeser marked it ready for review 02/15/21, 09:13

  6. TYPO3com voted on patch set 2 V +1 02/15/21, 09:24 Completed build in 11m 02s on Mon, 15 Feb, 09:24 AM Test Summary: 75335 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1096

  7. core-ci voted on patch set 2 V +1 02/15/21, 09:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/724

  8. Richard Haeser voted on patch set 2 V +2 CR +2 02/15/21, 09:33

  9. Richard Haeser merged patch set 3 02/15/21, 09:33