Review 10.4 Merged

67933[TASK] runTests.sh: Proper validation of -a option

Richard Haeser CR +2 V +2 Normal +54 −15 updated 02/15/21, 09:53

Commit message

Plus: No variable fallback magick in docker-compose.yml,
this belongs to runTests.sh

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Richard Haeser commented on patch set 1 02/15/21, 09:41

    Cherry Picked from branch master.
  2. Christian Kuhn voted on patch set 1 CR +1 02/15/21, 09:44

  3. Christian Kuhn voted on patch set 1 V +1 02/15/21, 09:46

  4. TYPO3com voted on patch set 1 V +1 02/15/21, 09:52 Completed build in 11m 02s on Mon, 15 Feb, 09:52 AM Test Summary: 75335 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1097

  5. core-ci voted on patch set 1 V +1 02/15/21, 09:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/727

  6. Richard Haeser voted on patch set 1 V +2 CR +2 02/15/21, 09:53

  7. Richard Haeser merged patch set 2 02/15/21, 09:53