Review 10.4 Merged

67934[BUGFIX] Quote identifier `colPos` in documentation example

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 02/15/21, 20:17

Commit message

The `colPos` identifier must be quoted - triggered by `{#colPos}`
in TypoScript - to make the database query work on database systems
that support case-sensitive identifiers (e.g. like PostgreSQL).

See
https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/8.7/Importa
nt-80506-DbalCompatibleFieldQuotingInTypoScript.html and
https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/Functions
/Select.html#quoting-of-fields

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Anja Leichsenring commented on patch set 1 02/15/21, 19:55

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/15/21, 20:05 Completed build in 09m 18s on Mon, 15 Feb, 08:05 PM Test Summary: 75335 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1101

  3. core-ci voted on patch set 1 V +1 02/15/21, 20:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/753

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/15/21, 20:17

  5. Anja Leichsenring merged patch set 2 02/15/21, 20:17