Review 10.4 Merged

67937[BUGFIX] Do not try to resolve TypoScript [ELSE] condition

Richard Haeser CR +2 V +2 Easy +16 −0 updated 02/17/21, 18:58

Commit message

Symfony Expression language can't resolve the TypoScript
[ELSE] condition. Instead a parsing error is logged which
is not helpful for users, who may believe, that [ELSE] is
not supported any more.

Therefore the Expression Language resolver now does not
parse the [ELSE] condition any more returns false instead.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 35

  1. Richard Haeser commented on patch set 1 02/17/21, 18:42

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/17/21, 18:53 Completed build in 10m 47s on Wed, 17 Feb, 06:52 PM Test Summary: 75341 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1112

  3. core-ci voted on patch set 1 V +1 02/17/21, 18:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/811

  4. Richard Haeser voted on patch set 1 V +2 CR +2 02/17/21, 18:58

  5. Richard Haeser merged patch set 2 02/17/21, 18:58