Review 10.4 Merged

67938[BUGFIX] Use site name rather than pageUid for calling context menu

Richard Haeser CR +2 V +2 Easy +2 −2 updated 02/17/21, 20:09

Commit message

PageTree Acceptance tests must not rely on pageUids, as those can
change unexpected. Better to find the page via its title.

Credits to Christian Kuhn for coming up with the xpath.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Richard Haeser commented on patch set 1 02/17/21, 19:56

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/17/21, 20:07 Completed build in 11m 04s on Wed, 17 Feb, 08:07 PM Test Summary: 75341 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1113

  3. core-ci voted on patch set 1 V +1 02/17/21, 20:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/813

  4. Richard Haeser voted on patch set 1 V +2 CR +2 02/17/21, 20:09

  5. Richard Haeser merged patch set 2 02/17/21, 20:09