Review 9.5 Merged

67939[BUGFIX] Use site name rather than pageUid for calling context menu

Richard Haeser CR +2 V +2 Easy +2 −2 updated 02/17/21, 20:16

Commit message

PageTree Acceptance tests must not rely on pageUids, as those can
change unexpected. Better to find the page via its title.

Credits to Christian Kuhn for coming up with the xpath.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 59

  1. Richard Haeser commented on patch set 1 02/17/21, 19:58

    Cherry Picked from branch 10.4. The following files contain Git conflicts: * typo3/sysext/core/Tests/Acceptance/Backend/PageTree/PageTreeFilterCest.php
  2. TYPO3com voted on patch set 1 V -1 02/17/21, 19:59 Completed build in 17s on Wed, 17 Feb, 07:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1003

  3. Richard Haeser commented on patch set 2 02/17/21, 20:00

    Published edit on patch set 1.
  4. Richard Haeser commented on patch set 2 02/17/21, 20:00

    This change is ready for review.
  5. core-ci voted on patch set 1 V -1 02/17/21, 20:00 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/814

  6. TYPO3com voted on patch set 2 V +1 02/17/21, 20:12 Completed build in 12m 15s on Wed, 17 Feb, 08:12 PM Test Summary: 75292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1004

  7. core-ci voted on patch set 2 V +1 02/17/21, 20:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/815

  8. Richard Haeser voted on patch set 2 V +2 CR +2 02/17/21, 20:16

  9. Richard Haeser merged patch set 3 02/17/21, 20:16