Review 10.4 Merged

68074[BUGFIX] Import data from yaml imports in declaration order

Richard Haeser CR +2 V +2 Normal +108 −0 updated 02/23/21, 14:37

Commit message

For plain arrays it's sometimes important that the items
appear in the order in which they are imported. For example
with the languages in the sites configuration where the first
language is seen as the default language.

Just like with Symfony Service Container imports come first
and its settings are overwritten with the main file. To make
sure that multiple imports are loaded in the order as they
appear in the main file they must be processed in reverse
order.

This behaviour can now be controlled by a new feature toggle
which defaults to `false` for existing and to `true` for new
installations.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 6

Review log 511

  1. Richard Haeser commented on patch set 1 02/23/21, 12:59

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Configuration/DefaultConfiguration.php * typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml * typo3/sysext/core/Configuration/FactoryConfiguration.php
  2. TYPO3com voted on patch set 1 V -1 02/23/21, 12:59 Completed build in 14s on Tue, 23 Feb, 12:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1122

  3. core-ci voted on patch set 1 V -1 02/23/21, 13:00 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/913

  4. Richard Haeser uploaded patch set 2 02/23/21, 13:22

  5. Richard Haeser commented on patch set 2 02/23/21, 13:29

    This change is ready for review.
  6. TYPO3com voted on patch set 2 V -1 02/23/21, 13:30 Completed build in 08m 25s on Tue, 23 Feb, 01:30 PM Test Summary: 1 of 75832 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1123

  7. core-ci voted on patch set 2 V +1 02/23/21, 13:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/915

  8. TYPO3com commented on patch set 2 02/23/21, 13:46 Completed build in 07m 48s on Tue, 23 Feb, 01:46 PM Test Summary: 1 of 75832 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1124

  9. TYPO3com voted on patch set 2 V +1 02/23/21, 14:36 Completed build in 10m 38s on Tue, 23 Feb, 02:36 PM Test Summary: 75347 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1126

  10. Richard Haeser voted on patch set 2 V +2 CR +2 02/23/21, 14:36

  11. Richard Haeser merged patch set 3 02/23/21, 14:37