Review 10.4 Merged

68115[BUGFIX] Set request object in EXT:form EmailFinisher

Christian Kuhn CR +2 V +2 Easy +6 −0 updated 02/25/21, 10:01

Commit message

Because the request object was not set for the FluidEmail
variant of the EXT:form EmailFinisher, the TYPO3 logo as
well as the website URL in the footer were not displayed
when using the SystemEmail layout from Core.

This is now fixed by setting the request, if available.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 36

  1. Christian Kuhn commented on patch set 1 02/25/21, 09:40

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 02/25/21, 09:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/991

  3. TYPO3com voted on patch set 1 V -1 02/25/21, 09:57 Completed build in 16m 10s on Thu, 25 Feb, 09:57 AM Test Summary: 1 of 75846 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1132

  4. TYPO3com voted on patch set 1 V +1 02/25/21, 10:00 Completed build in 35m 30s on Thu, 25 Feb, 10:00 AM Test Summary: 75361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1132

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 02/25/21, 10:01

  6. Christian Kuhn merged patch set 2 02/25/21, 10:01