Review 10.4 Merged

68116[BUGFIX] Enforce closing tags in Fluid f:form.button ViewHelper

Christian Kuhn CR +2 V +2 Easy +25 −0 updated 02/25/21, 16:20

Commit message

It's mandatory for HTML button elements to provide both,
the starting and the ending tag, even if no phrasing content
is provided.

See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button

This is now enforced in the corresponding ViewHelper.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 35

  1. Christian Kuhn commented on patch set 1 02/25/21, 16:05

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/25/21, 16:16 Completed build in 11m 16s on Thu, 25 Feb, 04:16 PM Test Summary: 75367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1134

  3. core-ci voted on patch set 1 V +1 02/25/21, 16:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1008

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 02/25/21, 16:19

  5. Christian Kuhn merged patch set 2 02/25/21, 16:20