Review 10.4 Merged

68122[TASK] Make ClassSchema PHP 8 compatible

Benni Mack CR +2 V +2 Easy +35 −8 updated 03/01/21, 20:13

Commit message

Several reflection methods are deprecated for a while
and throw errors with PHP8.

- ReflectionParameter::getClass()
- ReflectionParameter::isArray()

Both need to be replaced with the new api:

- ReflectionParameter::getType()

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 36

  1. Benni Mack commented on patch set 1 03/01/21, 19:11

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 03/01/21, 19:19 Completed build in 08m 02s on Mon, 1 Mar, 07:19 PM Test Summary: 1 of 75912 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1147

  3. TYPO3com voted on patch set 1 V +1 03/01/21, 19:21 Completed build in 18m 09s on Mon, 1 Mar, 07:21 PM Test Summary: 75426 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1147

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/01/21, 19:29

  5. Benni Mack merged patch set 2 03/01/21, 19:29

  6. core-ci voted on patch set 1 V +1 03/01/21, 20:13 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1097